Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure with Python 3.9.0 #44

Closed
fxcoudert opened this issue Oct 14, 2020 · 1 comment
Closed

Build failure with Python 3.9.0 #44

fxcoudert opened this issue Oct 14, 2020 · 1 comment

Comments

@fxcoudert
Copy link

fxcoudert commented Oct 14, 2020 •
edited
Loading

afflib 3.7.19 does not build with Python 3.9.0 (Homebrew/homebrew-core#62560), it gives the following error:

pyaff.c:2831:28: error: no member named 'tp_print' in 'struct _typeobject'

because (https://docs.python.org/3.9/whatsnew/3.9.html):

The tp_print slot of PyTypeObject has been removed. It was used for printing objects to files in Python 2.7 and before. Since Python 3.0, it has been ignored and unused

I suspect pyaff.c needs to be updated with a newer Cython.
@fxcoudert fxcoudert mentioned this issue Oct 14, 2020
Closed
sshock added a commit that referenced this issue Oct 16, 2020
@sshock
regenerate pyaff.c with a newer Cython
aeb444d 
Cython 0.29.21

to see if it helps with #44
@sshock
Copy link
Owner

sshock commented Oct 16, 2020

@fxcoudert I updated it; can you see if it works now?

@fxcoudert fxcoudert mentioned this issue Oct 23, 2020
Closed
@sshock sshock closed this as completed Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

afflib: migrate to [email protected] fxcoudert/homebrew-core
2 participants
@sshock @fxcoudert