Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HMACSHA1 implementation to external library #947

Closed
wants to merge 2 commits into from

Conversation

dd-morphi
Copy link

This is a workaround for #859 as described inside. It lasts for more than half a year and it will be good to have it in production.

@dd-morphi dd-morphi requested a review from drieseng as a code owner April 5, 2022 11:34
@dd-morphi
Copy link
Author

Is there a possibility to merge it?

@noahmehl
Copy link

+1 from us on this one

@Rob-Hague
Copy link
Collaborator

Thanks for the contribution (and the initial diagnosis). Closing this as the underlying issue is now fixed in 2023.0.0 (by virtue of updated target framework support).

@Rob-Hague Rob-Hague closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants