Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split PrivateKeyFile into different implementations. #1542

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

scott-xu
Copy link
Collaborator

@scott-xu scott-xu commented Nov 17, 2024

Abstract the implementations into IPrivateKeyParser.
It will be helpful when add new parsers, for example, PuTTY.
Prepare for #341, #431, #434, #510,

@Rob-Hague Rob-Hague merged commit 3ec45e1 into sshnet:develop Nov 20, 2024
1 check failed
@Rob-Hague
Copy link
Collaborator

It will be helpful when add new parsers, for example, PuTTY.

Are you planning on adding that? I saw some argon2-related stuff added to BouncyCastle

cc @darinkes

@darinkes
Copy link
Collaborator

Would be neat for sure to have it as part of the main project.

I use https://github.com/kmaragon/Konscious.Security.Cryptography since I don't use the whole BouncyCastle Lib.
But should be easy to replace the few bits with BouncyCastle, I think.

@scott-xu scott-xu deleted the privatekey-parser branch November 20, 2024 14:44
@scott-xu
Copy link
Collaborator Author

I also noted argon2 is added into BouncyCastle.
I'll have a try to add PuTTY support when I have free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants