Added ChangeDirectoryAsync to SftpClient #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snargledorf
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
|
May be relevant for #1415 |
Rob-Hague
approved these changes
Sep 24, 2024
Comment on lines
+290
to
+293
| sftp.DeleteDirectory("test1/test1_1"); | ||
| sftp.DeleteDirectory("test1/test1_2"); | ||
| sftp.DeleteDirectory("test1/test1_3"); | ||
| sftp.DeleteDirectory("test1"); |
There was a problem hiding this comment.
I assume these will become async with your other PR
| @@ -3993,6 +3992,36 @@ public void Sftp_ChangeDirectory_DirectoryDoesNotExist() | |||
| } | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public async Task Sftp_ChangeDirectory_DirectoryDoesNotExistAsync() | |||
There was a problem hiding this comment.
Seems like we have some duplicate/redundant tests between this and the "old" tests files 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.