Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface to SshClient #1499

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Add interface to SshClient #1499

merged 1 commit into from
Sep 21, 2024

Conversation

eugencowie
Copy link
Contributor

Changes:

  • Add ISshClient interface containing all public methods of SshClient
  • Make SshClient implement ISshClient
  • Update documentation comments in SshClient to inherit from ISshClient
  • Add missing public event from BaseClient to IBaseClient

Closes #1486

@eugencowie eugencowie mentioned this pull request Sep 19, 2024
Closed
Rob-Hague
Rob-Hague approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@Rob-Hague Rob-Hague merged commit 82246e3 into sshnet:develop Sep 21, 2024
1 check passed
@eugencowie eugencowie deleted the ssh-client-interface branch September 21, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob-Hague Rob-Hague Rob-Hague approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interface to SshClient
2 participants
@eugencowie @Rob-Hague