Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NuGet Central Package Management #1488

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

mus65
Copy link
Contributor

@mus65 mus65 commented Sep 8, 2024

This migrates to Central Package Management . Versions stay the same, so there is no functional difference.

Additional changes I made as part of this:

  • replaced some usages of the [1.0.0,) syntax with 1.0.0 since these are equivalent, see docs
  • removed the testcontainers -> SSH.NET exclude from IntegrationTests . I can not reproduce this issue anymore. Even if it still woud be a problem, I think it would be better to use VersionOverride here since the version has no meaning anyway.

@Rob-Hague
Copy link
Collaborator

Just want to double check the exclude, not sure why there would be no build warnings anymore

@mus65
Copy link
Contributor Author

mus65 commented Sep 11, 2024

I can only reproduce the original warning with Testcontainers <= 3.5.0 which depended on SSH.NET 2020.0.2 . With Testcontainers >= 3.6.0 (which depends on SSH.NET 2023.0.0), the warning disappears.

Still no idea why this makes a difference though.

Directory.Packages.props Show resolved Hide resolved
Directory.Packages.props Show resolved Hide resolved
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking the build warnings. Let's be optimistic that it won't reoccur

@Rob-Hague Rob-Hague merged commit dde5f67 into sshnet:develop Sep 11, 2024
1 check failed
@mus65 mus65 deleted the centralpackagemanagement branch September 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants