[Ed25519] Use BouncyCastle instead of Chaos.NaCl #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-xu
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
|
Was going to remove the whole Chaos.NaCl folder once several other PRs get merged. Do you want me to remove it piece by piece? |
Rob-Hague
approved these changes
Jul 23, 2024
| @@ -91,8 +92,7 @@ public ED25519Key(SshKeyData publicKeyData) | |||
| throw new ArgumentException($"Invalid Ed25519 public key data ({publicKeyData.Name}, {publicKeyData.Keys.Length}).", nameof(publicKeyData)); | |||
| } | |||
|
|
|||
| PublicKey = publicKeyData.Keys[0].ToByteArray().Reverse().TrimLeadingZeros().Pad(Ed25519.PublicKeySizeInBytes); | |||
| PrivateKey = new byte[Ed25519.ExpandedPrivateKeySizeInBytes]; | |||
| PublicKey = publicKeyData.Keys[0].ToByteArray().Reverse().TrimLeadingZeros().Pad(Ed25519.PublicKeySize); | |||
There was a problem hiding this comment.
I'd just keep the PrivateKey not-null unless we enable nullability here
Suggested change
| PublicKey = publicKeyData.Keys[0].ToByteArray().Reverse().TrimLeadingZeros().Pad(Ed25519.PublicKeySize); | |
| PublicKey = publicKeyData.Keys[0].ToByteArray().Reverse().TrimLeadingZeros().Pad(Ed25519.PublicKeySize); | |
| PrivateKey = new byte[Ed25519.SecretKeySize]; |
I think either way is fine |
scott-xu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.