Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to collect nuget packages in appveyor.yml as the packages are not generated when build #1317

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

scott-xu
Copy link
Collaborator

No nupkg nor snupkg is generated at this moment. We can add these 2 lines back later if we decide to generate nuget packages when build.

No nupkg nor snupkg is generated at this moment. We can add these 2 lines back later if we decide to generate nuget packages when build.
@Rob-Hague
Copy link
Collaborator

Could you also delete the artifacts/tcpdump.pcap comments while you are here?

@scott-xu
Copy link
Collaborator Author

Could you also delete the artifacts/tcpdump.pcap comments while you are here?

TBH, I'm not familiar with this .pcap file in artifacts folder. I know it has already been commented out, but this PR is focused on not collecting nuget packages.
And I know this PR's title is not intuitive. But if we want to have a better name, it would be easy when concentrate on one thing.

@scott-xu scott-xu changed the title Update appveyor.yml No need to collect nuget packages in appveyor.yml as the packages are not generated when build Feb 13, 2024
@Rob-Hague
Copy link
Collaborator

Thanks. I've removed them (I added them)

@WojciechNagorski WojciechNagorski merged commit 7d357e8 into sshnet:develop Feb 13, 2024
1 check was pending
@scott-xu scott-xu deleted the patch-1 branch February 18, 2024 01:49
@WojciechNagorski WojciechNagorski added this to the 2024.0.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants