Require Microsoft.Bcl.AsyncInterfaces >=1.0.0 instead of =8.0.0 #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mus65
changed the title
|
@Rob-Hague can you make a review? |
This technically fixes 2 different issues: - previously SSH.NET would require exactly(!) version 8.0.0, which would cause issues in the future if e.g. a project using SSH.NET would try to update to version 9.0.0. In this case the constraint on the exact version would cause NuGet to refuse to upgrade to 9.0.0 (sshnet#1287) - PowerShell Core seems to have problems with Version 8.0.0, therefore downgrade the requirement to 1.0.0 (see darkoperator/Posh-SSH#558) I had to re-enable AutoGenerateBindingRedirects, otherwise there is a FileLoadException with net462 in one of the tests. I don't know why this was disabled in 3ecbd10 .
WojciechNagorski
approved these changes
Jan 5, 2024
|
This issue has been fixed in the 2024.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This technically fixes 2 different issues:
- previously SSH.NET would require exactly(!) version 8.0.0, which would
cause issues in the future if e.g. a project using SSH.NET would
try to update to version 9.0.0. In this case the constraint on the
exact version would cause NuGet to refuse to upgrade to 9.0.0 (#1287)
- PowerShell Core seems to have problems with Version 8.0.0, therefore
downgrade the requirement to 1.0.0 (see darkoperator/Posh-SSH#558)
I had to re-enable AutoGenerateBindingRedirects, otherwise there is a
FileLoadException with net462 in one of the tests. I don't know why this
was disabled in 3ecbd10 .