-
-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH #1229
Conversation
Suppress all errors in unit tests and integration tests.
…row ArgumentException.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see any value in enabling analyzers just to add a bunch of suppressions in the source, but otherwise it is fine for me.
@WojciechNagorski, can I also get your stamp of approval? |
Build times and general responsiveness in VS have taken a massive hit. I beg that we reconsider 🥺 |
@Rob-Hague, I'm perfectly fine with disabling (some of) the analyzers by default. I'll submit a new PR to get the build in an acceptable state. |
Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH.
Suppress all errors in unit tests and integration tests.