Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH #1229

Merged
merged 9 commits into from
Nov 1, 2023

Conversation

drieseng
Copy link
Member

Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH.
Suppress all errors in unit tests and integration tests.

@drieseng drieseng changed the title 3rd time is a sharm Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH Oct 29, 2023
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't see any value in enabling analyzers just to add a bunch of suppressions in the source, but otherwise it is fine for me.

src/Renci.SshNet/Channels/Channel.cs Outdated Show resolved Hide resolved
src/Renci.SshNet/Common/SshData.cs Outdated Show resolved Hide resolved
src/Renci.SshNet/Common/SshData.cs Outdated Show resolved Hide resolved
src/Renci.SshNet/Renci.SshNet.csproj Outdated Show resolved Hide resolved
src/Renci.SshNet/SftpClient.cs Outdated Show resolved Hide resolved
@drieseng
Copy link
Member Author

drieseng commented Nov 1, 2023

@WojciechNagorski, can I also get your stamp of approval?

@WojciechNagorski WojciechNagorski merged commit 508fc87 into develop Nov 1, 2023
@WojciechNagorski WojciechNagorski deleted the 3rd-time-is-a-sharm branch November 1, 2023 10:33
@Rob-Hague
Copy link
Collaborator

Build times and general responsiveness in VS have taken a massive hit. I beg that we reconsider 🥺

@drieseng
Copy link
Member Author

drieseng commented Nov 3, 2023

@Rob-Hague, I'm perfectly fine with disabling (some of) the analyzers by default. I'll submit a new PR to get the build in an acceptable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants