Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep-alives are not activated if connection is already opened #334

Closed
gordonwatts opened this issue Nov 4, 2017 · 3 comments
Closed

Keep-alives are not activated if connection is already opened #334

gordonwatts opened this issue Nov 4, 2017 · 3 comments
Assignees
@drieseng
Labels
bug
Milestone
2020.0.0-beta1

Comments

@gordonwatts
Copy link

It looks to me like the following sequence of operations has a silent ignore in it:

  1. Create a connection and open it
  2. Set the KeepAliveInterval
  3. Monitor for a keepalive.

It looks like you start the keep alive timer in BaseClient only when the connection is opened. And in that code you only create the timer if the user has requested a keepalive time. By default, that isn't the case. When you change the KeepAliveInterval, it notices there is no timer, and so does nothing. Hence, the timer isn't set.
@drieseng drieseng added the bug label Nov 5, 2017
@drieseng drieseng self-assigned this Nov 5, 2017
@drieseng drieseng changed the title KeepAliveInterval logic not correct if a connection is already opened Keep-alives are not activated if connection is already opened Nov 5, 2017
@drieseng drieseng added this to the 2017.0.0-beta1 milestone Nov 5, 2017
drieseng added a commit that referenced this issue Nov 5, 2017
@drieseng
Ensure keep-alive timer is created when KeepAliveInterval is set afte…
66dcb0b 
…r the connection has been established.

Fixes issue #334.
@drieseng
Copy link
Member

drieseng commented Nov 5, 2017

Fixed in develop branch, and in upcoming 2017.0.0-beta1 release.
Thanks for reporting the issue!

@drieseng drieseng closed this as completed Nov 5, 2017
@gordonwatts
Copy link
Author

Thanks!!!

@drieseng drieseng modified the milestones: 2017.0.0-beta1, 2020.0.0-beta1 Mar 5, 2020
@drieseng
Copy link
Member

drieseng commented Jun 7, 2020

@gordonwatts 2020.0.0-beta1 is now available, and includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drieseng drieseng

Labels
bug
Projects
None yet
Milestone
2020.0.0-beta1
Development

No branches or pull requests
2 participants
@drieseng @gordonwatts