Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor redesign and optimization of (Private)Key classes #1128

Closed
drieseng opened this issue May 28, 2023 · 3 comments · Fixed by #1264
Closed

Minor redesign and optimization of (Private)Key classes #1128

drieseng opened this issue May 28, 2023 · 3 comments · Fixed by #1264
Milestone
2023.0.1

Comments

@drieseng
Copy link
Member

drieseng commented May 28, 2023 •
edited
Loading

  • Remove _privateKey field from Key base class.
  • Remove ctor(byte[] data) from Key, and move current implementation to RsaKey and DsaKey classes.
  • The ctor(byte[] data of RsaKey and DsaKey can be optimized to remove intermediate List<BigInteger>.
  • Remove initial assignment of _publicKey from ED25519Key(byte[] pk, byte[] sk)ctor.
  • Rename privateKey field in ED25519Key to _privateKey and remove disable of IDE1006 for this field.
@drieseng
Copy link
Member Author

cc: @WojciechNagorski

@WojciechNagorski
Copy link
Collaborator

I don't mind. It looks like a great idea. IDE1006 is also a good role.

Rob-Hague added a commit to Rob-Hague/SSH.NET that referenced this issue Jul 15, 2023
@Rob-Hague
sshnet#1128
d84fb25
@Rob-Hague Rob-Hague mentioned this issue Dec 8, 2023
Merged
@WojciechNagorski WojciechNagorski added this to the 2023.0.1 milestone Dec 21, 2023
@WojciechNagorski
Copy link
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.0.1
Development

Successfully merging a pull request may close this issue.

Make keys immutable Rob-Hague/SSH.NET
2 participants
@drieseng @WojciechNagorski