Remove CS1591 nowarn from concrete test projects as this is already d…

…efined in the Directory.Build.props that is in the test folder.
sshnet · Oct 13, 2023 · 20f4bc1 · 20f4bc1
1 parent 1cc6846
commit 20f4bc1
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 48 deletions.
diff --git a/test/Renci.SshNet.Benchmarks/Renci.SshNet.Benchmarks.csproj b/test/Renci.SshNet.Benchmarks/Renci.SshNet.Benchmarks.csproj
@@ -1,19 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-      <!--
-          Even though we're not interested in producing XML docs for test projects, we have to enable this in order to have the .NET Compiler
-          Platform analyzers produce the IDE0005 (Remove unnecessary import) diagnostic.
-            
-          To avoid warnings for missing XML docs, we add CS1591 (Missing XML comment for publicly visible type or member) to the NoWarn property.
-          We can stop producing XML docs for test projects (and remove the NoWarn for CS1591) once the following issue is fixed:
-          https://github.com/dotnet/roslyn/issues/41640.
-      -->
-      <NoWarn>$(NoWarn);CS1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
@@ -27,5 +17,4 @@
   <ItemGroup>
       <EmbeddedResource Include="..\Data\*.txt" LinkBase="Data" />
   </ItemGroup>
-
 </Project>
diff --git a/test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj b/test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj
@@ -3,20 +3,9 @@
   <PropertyGroup>
     <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
-
     <IsPackable>false</IsPackable>
     <IsTestProject>true</IsTestProject>
-    <!--
-          Even though we're not interested in producing XML docs for test projects, we have to enable this in order to have the .NET Compiler
-          Platform analyzers produce the IDE0005 (Remove unnecessary import) diagnostic.
-            
-          To avoid warnings for missing XML docs, we add CS1591 (Missing XML comment for publicly visible type or member) to the NoWarn property.
-
-          We can stop producing XML docs for test projects (and remove the NoWarn for CS1591) once the following issue is fixed:
-          https://github.com/dotnet/roslyn/issues/41640.
-      -->
-    <NoWarn>$(NoWarn);CS1591;SYSLIB0021;SYSLIB1045;SYSLIB0014;IDE0220;IDE0010</NoWarn>
-
+    <NoWarn>$(NoWarn);SYSLIB0021;SYSLIB1045;SYSLIB0014;IDE0220;IDE0010</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(TargetFramework)' == 'net7.0' ">
@@ -27,7 +16,6 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
     <PackageReference Include="MSTest.TestAdapter" Version="3.1.1" />
     <PackageReference Include="MSTest.TestFramework" Version="3.1.1" />
-
     <PackageReference Include="Testcontainers" Version="3.4.0" />
     <PackageReference Include="System.Management" Version="4.7.0" />
     <!--
@@ -40,7 +28,6 @@
         To fix, we explicitly exclude the SSH.NET nuget package from this project's dependencies.
     -->
     <PackageReference Include="SSH.NET" Version="2020.0.2" ExcludeAssets="All" />
-
     <PackageReference Include="coverlet.collector" Version="6.0.0">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
@@ -51,6 +38,7 @@
     <ProjectReference Include="..\Renci.SshNet.TestTools.OpenSSH\Renci.SshNet.TestTools.OpenSSH.csproj" />
     <ProjectReference Include="..\..\src\Renci.SshNet\Renci.SshNet.csproj" />
   </ItemGroup>
+
   <ItemGroup>
     <EmbeddedResource Include="resources\client\id_dsa" />
     <EmbeddedResource Include="resources\client\id_dsa.ppk" />

diff --git a/test/Renci.SshNet.TestTools.OpenSSH/Renci.SshNet.TestTools.OpenSSH.csproj b/test/Renci.SshNet.TestTools.OpenSSH/Renci.SshNet.TestTools.OpenSSH.csproj
@@ -3,19 +3,11 @@
         <TargetFramework>net7.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
-
-        <!--
-          Even though we're not interested in producing XML docs for test projects, we have to enable this in order to have the .NET Compiler
-          Platform analyzers produce the IDE0005 (Remove unnecessary import) diagnostic.
-            
-          To avoid warnings for missing XML docs, we add CS1591 (Missing XML comment for publicly visible type or member) to the NoWarn property.
-
-          We can stop producing XML docs for test projects (and remove the NoWarn for CS1591) once the following issue is fixed:
-          https://github.com/dotnet/roslyn/issues/41640.
-      -->
-        <NoWarn>$(NoWarn);CS1591;SYSLIB0021;SYSLIB1045</NoWarn>
+        <NoWarn>$(NoWarn);SYSLIB0021;SYSLIB1045</NoWarn>
     </PropertyGroup>
     <ItemGroup>
-      <Folder Include="Properties\" />
+      <Compile Remove="Properties\**" />
+      <EmbeddedResource Remove="Properties\**" />
+      <None Remove="Properties\**" />
     </ItemGroup>
 </Project>
diff --git a/test/Renci.SshNet.Tests/Renci.SshNet.Tests.csproj b/test/Renci.SshNet.Tests/Renci.SshNet.Tests.csproj
@@ -1,16 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFrameworks>net462;net6.0;net7.0</TargetFrameworks>
-    <!--
-          Even though we're not interested in producing XML docs for test projects, we have to enable this in order to have the .NET Compiler
-          Platform analyzers produce the IDE0005 (Remove unnecessary import) diagnostic.
-            
-          To avoid warnings for missing XML docs, we add CS1591 (Missing XML comment for publicly visible type or member) to the NoWarn property.
-
-          We can stop producing XML docs for test projects (and remove the NoWarn for CS1591) once the following issue is fixed:
-          https://github.com/dotnet/roslyn/issues/41640.
-      -->
-    <NoWarn>$(NoWarn);CS1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
@@ -32,13 +22,13 @@
     <MSTestV1UnitTestFrameworkAssembly Condition="'$(MSTestV1UnitTestFrameworkAssembly)' == '' and Exists('$(MSTestV1UnitTestFrameworkAssemblyCandidate)')">$(MSTestV1UnitTestFrameworkAssemblyCandidate)</MSTestV1UnitTestFrameworkAssembly>
   </PropertyGroup>
 
-
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
     <PackageReference Include="MSTest.TestAdapter" Version="3.1.1" />
     <PackageReference Include="MSTest.TestFramework" Version="3.1.1" />
     <PackageReference Include="Moq" Version="4.18.4" />
   </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\..\src\Renci.SshNet\Renci.SshNet.csproj" />
   </ItemGroup>