use x/crypto #15
Closed
use x/crypto #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this uses a fork of x/crypto where edwards25519 is not internal. This seemed like the easiest change to port agl's extra25519 to x/crypto. We carry it as our internal package for now. We just took PrivateKeyToCurve25519 and PublicKeyToCurve25519 since that is all that we need.
|
Background: agl/ed25519#27 (comment) |
|
The main annoyance here is that go.mod's
The branch is here: https://github.com/cryptix/golang_x_crypto/tree/non-internal-edwards |
This was referenced Mar 4, 2020
cryptix
added a commit
to ssbc/go-ssb-room
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses a fork of x/crypto where edwards25519 is not internal. This seemed like the easiest change to port agl's extra25519 to x/crypto.
We carry it as our internal package for now. We just took PrivateKeyToCurve25519 and PublicKeyToCurve25519 since that is all that we need.