Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support webpack #283

Closed
wants to merge 2 commits into from
Closed

Added support webpack #283

wants to merge 2 commits into from

Conversation

SuperPaintman
Copy link

Hi!
I added exports from module and import angular library from CommonJS / AMD.

const angular = require('angular');
const ngInfiniteScroll = require('ng-infinite-scroll');

angular.module('App', [
  ngInfiniteScroll // <- exports string with module name
])

$interval.cancel checkInterval
)
]
.name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Collaborator

@graingert graingert Jun 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traditionally you do something like:

const MODULE_NAME = 'infinite-scroll';
angular.module(MODULE_NAME).directive(...).component(...); // etc...
return MODULE_NAME;

@SuperPaintman
Copy link
Author

@graingert done

@graingert
Copy link
Collaborator

closing in favour of #271

@graingert graingert closed this Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants