Removed 'checkWhenEnabled' flag from source. #279
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkWhenEnabled flag is an unnecessary optimization that interferes with filterable lists that are too short to trigger scroll events. It seems reasonable that every time infinite scroll changes from the disabled state to the enabled state it should call its handler to determine if it should scroll.
Here is a common scenario:
None of the steps after step 1 listed above would have triggered the handler. I am proposing that the handler should be triggered every time infinite-scroll moves to the enabled state (step 5 above). This would solve the problem and lead to more consistent behavior.
Thanks for your time.