Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update marker PDF for SR2025 #620

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Update marker PDF for SR2025 #620

merged 3 commits into from
Oct 11, 2024

Conversation

WillB97
Copy link
Contributor

@WillB97 WillB97 commented Oct 10, 2024

As generated in srobo/game-markers#18

@WillB97 WillB97 requested a review from a team October 10, 2024 20:05
RealOrangeOne
RealOrangeOne requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected pending feedback on srobo/game-markers#18

RealOrangeOne
RealOrangeOne approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be squash merged to avoid polluting the repo with the erroneous marker PDFs

@WillB97 WillB97 merged commit e3357d3 into main Oct 11, 2024
6 checks passed
@WillB97 WillB97 deleted the sr2025-markers branch October 11, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealOrangeOne RealOrangeOne RealOrangeOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillB97 @RealOrangeOne