Refactor the tree provider #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return an error (this implicitly shows the error window) - Use the lab name, instead of label (which is name + owner)
- Put graph functions in their own group - Move inspect lab above graph functions
FloSch62
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Tree Provider
Containers and lab items on the tree are now two separate classes. A lab node has it's children (lab containers) stored in itself as an array.
Everything is 'stricter' now that labs and containers are separate classes, and there are only minimal things that can be 'undefined' now.
I've added an enum for the lab states, which will help with getting the icons directly.
Overall the refactor improves the readability of the code, as well as making it easier to implement certain features down the line (such as the interface discovery for pcap, etc.)