Support @bufbuild/protobuf
#1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sri Krishna <[email protected]>
srikrsna-buf
commented
Sep 4, 2025
Owner
Author
srikrsna-buf
left a comment
srikrsna-buf
left a comment
There was a problem hiding this comment.
Figuring out the tests
| bool grpc_js; | ||
| // Omit instanceof check for messages in serialize methods | ||
| bool omit_serialize_instanceof; | ||
| // Runtime to use for protobuf serialization (default: "google-protobuf", "es" for @bufbuild/protobuf) |
Owner
Author
There was a problem hiding this comment.
Perhaps we should use bufbuild-protobuf instead of es
Collaborator
There was a problem hiding this comment.
Would be a better fit for the "runtime" argument. I wouldn't change the example directory name, and it isn't feasible to change --es_out.
timostamm
reviewed
Sep 9, 2025
| bool grpc_js; | ||
| // Omit instanceof check for messages in serialize methods | ||
| bool omit_serialize_instanceof; | ||
| // Runtime to use for protobuf serialization (default: "google-protobuf", "es" for @bufbuild/protobuf) |
Collaborator
There was a problem hiding this comment.
Would be a better fit for the "runtime" argument. I wouldn't change the example directory name, and it isn't feasible to change --es_out.
| } | ||
|
|
||
| grpc::string NodeObjectPath(const Descriptor* descriptor) { | ||
| grpc::string NodeObjectPath(const Descriptor* descriptor, const grpc::string& runtime) { |
Collaborator
There was a problem hiding this comment.
Don't know how to test it, but the diff looks good to me.
Fix example
Signed-off-by: Sri Krishna <[email protected]>
timostamm
reviewed
Sep 10, 2025
Signed-off-by: Sri Krishna <[email protected]>
timostamm
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
@bufbuild/protobufruntimeThis PR adds support for generating service definitions compatible with the
@bufbuild/protobufruntime, a popular and conformant protobuf implementation.What this PR does:
Adds a new plugin option called
runtimeto select the protobuf runtime. Supported values arebufbuild-protobufand defaults to usegoogle-protobuf. When the runtime is set tobufbuild-protobuf, the plugin generates service definitions that use@bufbuild/protobuf's message types and serialization methods instead of the default runtime.Why this change?
@bufbuild/protobufsupports Editions and passes significantly more conformance tests than currently supported runtimes, ensuring better protocol buffer compatibility.Usage
Alongside
grpc-tools, users will need to install@bufbuild/protoc-gen-esand change thegrpc_tools_node_protoccall to use the new runtime and use theprotoc-gen-es:Alternatives
Happy to discuss other options like a separate runtime package or plugin package. Having either of those will also bring TypeScript and ESM support.