Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devShell submodule; allow disabling dev environment #61

Merged
merged 7 commits into from
Feb 5, 2023

Conversation

srid
Copy link
Owner

@srid srid commented Feb 5, 2023

Resolves #37 (to be squash merged)

  • Group buildTools (renamed to tools), hlsCheck and hlintCheck under the devShell submodule option
  • Allow disabling them all using devShell.enable = false; (useful if you want haskell-flake to produce just the package outputs).

cc @Kranzes

@srid srid changed the title Add devShell submodule Add devShell submodule; allow disabling dev environment Feb 5, 2023
@srid
Copy link
Owner Author

srid commented Feb 5, 2023

Aside: regarding defaultBuildTools, perhaps that can be decoupled into a separate haskell-flake module, having the user explicitly do:

haskellProjects.foo.imports = [
  inputs.haskell-flake.defaults
];

Less magic this way, as suggested by @maralorn

srid added a commit to srid/haskell-template that referenced this pull request Feb 5, 2023
@srid srid merged commit 014aa62 into master Feb 5, 2023
@srid srid deleted the devShellSubmodule branch February 5, 2023 19:06
@maralorn
Copy link

maralorn commented Feb 6, 2023

Nice. I didn’t know that there was a trick to null some of those default tools. Having some tools in there by default is fine. You shouldn’t change that.

I would just suggest that you list which tools those are in the example and in the option description. Also explain how to null them in the option description, probably best via the example value for the option.

@Kranzes
Copy link

Kranzes commented Feb 6, 2023

Good stuff Srid, I remember I suggested you to have it this way months ago and you said that it defeats the whole purpose of the project which I disagreed with. It's good that now I won't be forced to having a devshell when sometimes all I want is to package something with a better interface for cabal2nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable the development environment
3 participants