Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildFromSdist: enable only for local packages #298

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

srid
Copy link
Owner

@srid srid commented Apr 3, 2024

#291 (comment)

Resolves #292

@shivaraj-bh
Copy link
Contributor

was it intended to be defaults.settings.defined here? or was it supposed to be defaults.settings.local?

@srid
Copy link
Owner Author

srid commented Apr 22, 2024

It should be defined.

Wait, the last PR reverted this change, no?

I see this under settings.all:

buildFromSdist = lib.mkDefault true;

@shivaraj-bh
Copy link
Contributor

Wait, the last PR reverted this change, no?

Shoot, I messed up while resolving merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildFromSdist fails with Rust packages
2 participants