-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devShell to eagerly evaluated? #270
Comments
Can confirm. Here's a trace with hercules-ci-agent. Trace
The culprit is Expect an eval performance boost when this is fixed. |
This means we don't support `mkIf` in the exact places where the type was `attrsOf`. Almost always, `mkIf` can be replaced by `optionalAttrs`. The benefit is that the code becomes much lazier, improving performance and - Fixes srid#270
Does that PR fix it? Because haskell-flake/nix/modules/project/devshell.nix Lines 19 to 20 in 938888c
|
I've tried |
This means we don't support `mkIf` in the exact places where the type was `attrsOf`. Almost always, `mkIf` can be replaced by `optionalAttrs`. The benefit is that the code becomes much lazier, improving performance and - Fixes #270
According to the trace I got from the haskell-flake |
jup, worked for me, thank you @roberth <3 |
to reproduce
basePackages = pkgs.haskell.packages.ghc90
devShell.enable = false
this should eval error:
I'm suspecting that there is some issue with the
devShell
being evaluated to eagerly; the package shouldn't depend onhaskell-language-server
and doesn't try to evaluate/ build it in all other projectsThe text was updated successfully, but these errors were encountered: