Test dupe toast stream #55
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srcrip I finally got around to writing a test to demonstrate the problem with
live_renderandput_flash.Basically, the "inner" LiveView being live-rendered has its own flash assigns so we need some kind of inner-rendered flash group.
The new test passes with warnings about duplicate HTML IDs.
This is why I made the other PR a long time ago to fix dupe HTML IDs.
#24
I can go ahead and fix it again in this PR but want to get your feedback before I continue to make sure you agree it is a problem.