-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gemini Ai Support #446
Conversation
Resolved all the issue, the gemini api is working smoothly. Please do let me know in any case there could be any scope of improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me! Will test it this weekend before merging but I think this is good to go!
@@ -20,9 +20,9 @@ | |||
"@changesets/cli": "^2.27.8", | |||
"@srcbook/configs": "workspace:^", | |||
"@types/node": "^20.14.2", | |||
"eslint": "^8.57.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal but why change this order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, we can ignore this during the integration I was getting a type error which I thought could be resolved by having ai-sdk for Google installed in the root package when I later realized it has nothing to with it, I removed it from package.json for avoiding not so necessary installation in the package. And honestly I didn't realized that it changed the order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this particular commit as well btw! I don't know how it got committed because I remembered I removed the dependency, if it's possible to not align with the following package.json then it works because we have nothing to do with root's package.json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging!
You can check Feature from here
Please let me know
fix: #445