Re-introduce streaming with fixed bugs #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving progress. Some things work but tags are wonky Fix streaming bugs
|
Rebase broke this. Making a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed up a few bugs.
This thing is very stateful and even though it didn't break during some basic testing, I would not be surprised to find more bugs.
The bugs often have to do with the difficulty of parsing CDATA vs non CDATA sections, how we manage the currentTag stack, and generally mutability of the buffer.
I have ideas on how we can improve it when we reimplement it later.
This PR also removes the "create a version" mechanism in the frontend when there is only an npm install command.