-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream LLM response when editing apps #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM. Given how this works, we should be able to populate the DiffBox temporarily with "updating ${filename}..." Although we need to be careful to not make that clickable otherwise if users click on the file we'll interrupt the request |
nichochar
approved these changes
Oct 29, 2024
I realized that we could also push the file streams another way:
|
Yes for sure, we can improve this a lot beyond this first pass. |
nichochar
added a commit
that referenced
this pull request
Oct 30, 2024
This reverts commit a6bfde7.
nichochar
added a commit
that referenced
this pull request
Oct 30, 2024
nichochar
added a commit
that referenced
this pull request
Oct 31, 2024
* Streaming WIP * More wip * Fix up the streaming parser and the tests * Remove extra debug log * Remove unused file * Fix more parser bugs * Hook up frontend --------- Co-authored-by: Nicholas Charriere <[email protected]>
nichochar
added a commit
that referenced
this pull request
Oct 31, 2024
* Stream LLM response when editing apps (#430) * Streaming WIP * More wip * Fix up the streaming parser and the tests * Remove extra debug log * Remove unused file * Fix more parser bugs * Hook up frontend --------- Co-authored-by: Nicholas Charriere <[email protected]> * Add changes to bugfix * Saving progress. Some things work but tags are wonky * Fix streaming bugs * Remove debug log --------- Co-authored-by: Ben Reinhart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow ups: