Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install should always include sockets messages #412

Closed
wants to merge 4 commits into from

Conversation

1egoman
Copy link
Contributor

@1egoman 1egoman commented Oct 22, 2024

This change includes:

  • Adding socket broadcasts for all npm installs globally in the app
  • Making sure that if a process has a null port to not send that to the client, kill+restart it instead
    • I've noticed even with ben's recent change some situations where a null port makes its way to the client, so I'm hoping this makes that case impossible.
  • Hide the installation toast when a server driven npm install finishes
  • Temporarily disable npm install when starting the app: This is to eliminate possible cases as part of some experimentation
    • This should be undone before this change gets merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant