Effy small UI polish #411
Merged
Effy small UI polish #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/web/src/routes/home.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| const checkApiKey = () => { | ||
| const hasSeenOnboarding = localStorage.getItem('hasSeenOnboarding') === 'true'; |
There was a problem hiding this comment.
This should live in persistent storage (sqlite), at least in the medium-long term.
There was a problem hiding this comment.
I updated this logic to instead gate on whether aiEnabled being outputted from useSettings was enabled rather than segregating the onboarding state individually.
I don't think there's a reason that tracking this separately is important, given that this should be shown for all users that don't have an ai api key set - if so though, please call it out.
1egoman
force-pushed
the
effy-small-ui-polish
branch
from
cdf0bca to
6c090a6
Compare
…d reuse existing ai key management code
1egoman
force-pushed
the
effy-small-ui-polish
branch
from
3a91045 to
8b2900c
Compare
benjreinhart
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new onboarding screen which gates a user from visiting the application's home page until they've added an ai api key: