Install npm packages after plan ran. External link option #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/api/ai/plan-parser.mts
Outdated
| (action): action is NpmInstallCommand => | ||
| action.type === 'command' && action.command === 'npm install', | ||
| ) | ||
| .map((action) => action.packages) |
There was a problem hiding this comment.
.map().flat() can be expressed in one iteration using flatMap().
| <TooltipProvider> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Button |
There was a problem hiding this comment.
This should be a link rather than a button with window.open
| size="icon" | ||
| onClick={() => window.open(url as string, '_blank')} | ||
| className="active:translate-y-0" | ||
| disabled={previewStatus === 'booting' || previewStatus === 'connecting'} |
There was a problem hiding this comment.
nit but probs better to do previewStatus !== 'running', especially since at some point stop may keep the preview stopped (rather than client automatically booting it back up again, which is currently awkward behavior given that we have a stop button that doesn't really stop it).
| props.onChangeTab('code'); | ||
| }} | ||
| className="active:translate-y-0" | ||
| disabled={previewStatus === 'booting' || previewStatus === 'connecting'} |
There was a problem hiding this comment.
same re: previewStatus !== running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to open the vite app in a new tab (i want this to show something off in the video).
Also when creating an app, if there were packages they wouldn't be installed and it would crash. I fix that by installing only the right packages post AI plan.