Make WebSocket subscriptions receive ack to be considered subscribed #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to implement logic where we only send events once the server has confirmed our subscription. This ensures that the server will not try to broadcast something before we're subscribed, leading to events that never make it to the client.
This probably mostly only happens in dev because of the mounting/unmounting/remounting resulting in useEffect running multiple times initially. There's a small window where events can get dropped in that. In a production build, it's more unlikely we'd have issues here, but this is good in either case as subscriptions really should be acknowledged by the server before we start sending events.