Add folder delete and rename behavior #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichochar
approved these changes
Oct 12, 2024
| router.delete('/apps/:id/directories', cors(), async (req, res) => { | ||
| const { id } = req.params; | ||
|
|
||
| // TODO: validate and ensure path is not absolute |
There was a problem hiding this comment.
I've wanted some path cleaning utils also in other places, this is a good idea. It's particularly useful given that LLMs are giving us paths which i have less confidence in.
benjreinhart
force-pushed
the
filetree
branch
from
da0f1d8 to
4d92592
Compare
BeRecursive22
pushed a commit
to BeRecursive22/srcbook
that referenced
this pull request
Oct 13, 2024
* Add folder delete and rename behavior * Remove unused files state * Fix lint warnings
nichochar
pushed a commit
that referenced
this pull request
Oct 14, 2024
#333) * [FIX]:285 - Type proccess.env based off the available secrets in a notebook * [ADD] - changeset * [FIX] - linting and formatting * Style apps page sidebar and header (#340) * Update sans font (#341) * File tree functionality and styles (#344) * Add support for deleting and renaming files (#345) * Add support for deleting and renaming files * Fix lint * Exclude a few directories * Implement top level create file and folder (#346) * Homepage UI Rework! (#348) * inital homepage rework, sections, card style, srcbook to notebook * fix lil linter error * move user facing Srcbook (in ref to notebook) to Notebook * style up to match figma * some cleanup around purples on create app (#351) * fix CI bug with pnpm CI mismatch in release (#354) * Add logic to represent booting state within preview panel and parse stdout from vite to get port (#349) * feat: add logic to represent booting state within preview panel and parse stdout from vite to get port * fix: run npm run format * Add folder delete and rename behavior (#355) * Add folder delete and rename behavior * Remove unused files state * Fix lint warnings * [FIX] - env type errors * put the env.d.ts file under root directory instead of src * remove cell:format --------- Co-authored-by: Ben Reinhart <[email protected]> Co-authored-by: versecafe <[email protected]> Co-authored-by: Ryan Gaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix folder renaming, but otherwise this is good to go.