Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto-install dependencies for new typescript srcbook #339

Closed
wants to merge 3 commits into from
Closed

feat: add auto-install dependencies for new typescript srcbook #339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51a8a18
feat: add auto-install dependencies for new typescript srcbook
Sanjoy-droid Oct 8, 2024
0034e96
Merge branch 'main' into auto-install-deps
Sanjoy-droid Oct 8, 2024
8499b86
Merge branch 'main' into auto-install-deps
Sanjoy-droid Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions packages/web/src/routes/session.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,23 +310,8 @@ function Session(props: SessionProps) {
});
result = () => toast.dismiss(toastId);
} else if (outdatedDependencies) {
toast.warning('Packages need to be installed', {
duration: 10000,
action: {
label: 'Install',
onClick: () => {
// If outdatedDependencies is an array, it usually menas those packages are not present
// inside of package.json yet. Thus we must specifically install them by name so they are
// installed and added to package.json. Otherwise, we just need to install what is already
// listed inside of package.json.
if (Array.isArray(outdatedDependencies)) {
npmInstall(outdatedDependencies);
} else {
npmInstall();
}
},
},
});
// Discard all the other possibilities and just install npm
npmInstall();
}

return result;
Expand Down