Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read and write tsconfig to/from disk #160

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Read and write tsconfig to/from disk #160

merged 1 commit into from
Aug 1, 2024

Conversation

benjreinhart
Copy link
Contributor

This PR introduces support for editing tsconfig.json.

I did quite a bit of QA but we'll want to do more on this since it touches the parsing of srcmd and some other session related things.

@benjreinhart benjreinhart requested a review from nichochar July 27, 2024 01:22
@nichochar
Copy link
Contributor

LGTM, going to merge and do some QA. Things to do post merge:

  • publish @srcbook/shared package (this is safe bc backwards compatible)
  • QA the feature itself
  • QA the prompts and AI features, since we touched the prompt compilation code

@nichochar nichochar merged commit 8bd1a33 into main Aug 1, 2024
1 check passed
@nichochar nichochar deleted the tsconfig branch August 1, 2024 20:37
@benjreinhart benjreinhart mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichochar nichochar Awaiting requested review from nichochar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjreinhart @nichochar