Dont show secrets unless action is taken by user #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -264,13 +282,23 @@ function SecretRow(props: { | |||
| function NewSecretForm(props: { | |||
| setError: (message: string | null, clearAfter?: number | null) => void; | |||
| }) { | |||
| useHotkeys( | |||
There was a problem hiding this comment.
In all cases I've seen thus far for inputs, i find this pattern to be less obvious (the code is located somewhere other than the Input) and heavier weight than:
onKeydown={(e) => e.key === 'Enter' && onSubmit()}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the security vulnerability of accidentally showing secrets when sharing screen / streaming video.
Now it requires an explicit action from the user (see video).
Also added
cmd + entershortcut for submitting the formCleanShot.2024-07-23.at.16.34.12.mp4