Decouple srcmd from node libs and AI #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjreinhart
commented
Jul 17, 2024
| case 'markdown': | ||
| return encodeMarkdownCell(cell); | ||
| case 'placeholder': | ||
| return encodePlacebolderCell(cell); |
There was a problem hiding this comment.
@nichochar there shouldn't be a coupling here to AI-specific things, so we can instead represent a placeholder cell as a cell and then render whatever the contents of the cell's text is.
There was a problem hiding this comment.
This also allows it to be used for other things in the future if needed.
benjreinhart
commented
Jul 17, 2024
| // Make sure we copy cells so we don't mutate the session | ||
| const cellsWithPlaceholder: CellWithPlaceholderType[] = [...session.cells]; | ||
|
|
||
| cellsWithPlaceholder.splice(insertIdx, 0, { |
There was a problem hiding this comment.
Since CellWithPlaceholderType is a superset of the CellType, any existing calls or cell representations will succeed just fine, but here, in the one place we need to do something different, we can leverage this superset type and pass in the cell instead of relying on the encoder to know what to do for AI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.