Use tsserver geterr command & events. reloadProjects for file renames #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
nichochar
reviewed
Jul 15, 2024
| // TODO: Can we be smarter and only do this for cells that import | ||
| // this cell, rather than all cells? | ||
| sendAllTypeScriptDiagnostics(tsserver, session); | ||
| // TODO: Given the amount of differences here and elsewhere when renaming cells, |
There was a problem hiding this comment.
+1, I was thinking the same thing
| // NOTE: reloading the project sends diagnostic events without calling `geterr`. | ||
| // However, it seems to take a while for the diagnostics to be sent, so we still | ||
| // request it below. | ||
| // |
There was a problem hiding this comment.
nanonit: extra line here
| * 2. Response: A response from the server to a specific client request. | ||
| * 3. Event: An event from the server to the client. | ||
| * | ||
| * Request and responses are identified a unique number called `seq`. `seq` is incremented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of trial and error but looks like using
geterrcommand is better than thesemanticDiagnosticSynccommand:This PR also solves one annoying bug when renaming files
a.tsthat is imported byb.tstoc.tsb.tsthata.tsdoesn't existc.tsback toa.ts.b.tsthata.tsdoesn't exist.a.tsdoes exist.This PR issues the
reloadProjectscommand which gets it back to a working state.I also added more documentation.