Treat diagnostics as separate entity from stdout/stderr #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjreinhart
commented
Jul 11, 2024
| @@ -66,9 +69,9 @@ export function CellStdio({ cell, show, setShow }: PropsType) { | |||
| 'border-transparent data-[state=active]:border-transparent data-[state=active]:text-tertiary-foreground mb-0', | |||
| )} | |||
| > | |||
| {tscOutput.length > 0 ? ( | |||
| {diagnostics.length > 0 ? ( | |||
There was a problem hiding this comment.
We call this "problems" but right now we're sending all diagnostics to this tab. That includes warnings and suggestions. So... TODO: rework "Problems" tab to be something like "Diagnostics" which has different categories of diagnostics (error, warning, suggestion)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sends tsserver diagnostics over a separate websocket event as a rich diagnostic object rather than a string message. This paves the way to do things like add squiggly lines under sections with errors, or highlight lines with errors.
I made one other change in this PR which has bugged me for a while: When you clear output, you should only be clearing the output of the current tab, not all tabs, which is confusing and annoying if you didn't mean to do that.