Improve log message levels and error messages #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![lookout-staging[bot]](https://avatars.githubusercontent.com/u/15128793?s=60&v=4){kind=small}
dpordomingo
approved these changes
Dec 18, 2018
smacker
reviewed
Dec 19, 2018
service/git/syncer.go
Outdated
| @@ -78,7 +78,7 @@ func (s *Syncer) Sync(ctx context.Context, | |||
| } | |||
|
|
|||
| func (s *Syncer) fetch(ctx context.Context, repoInfo *lookout.RepositoryInfo, r *git.Repository, refspecs []config.RefSpec) (err error) { | |||
| ctxlog.Get(ctx).Infof("fetching references for repository %s: %v", repoInfo.CloneURL, refspecs) | |||
| ctxlog.Get(ctx).Debugf("fetching references for repository %s: %v", repoInfo.CloneURL, refspecs) | |||
There was a problem hiding this comment.
could you please check if we have any info level message somewhere in the callers that explains downloading?
I remember we make this one as info because fetching is a slow operation and it looks like lookoutd just hanged without it.
There was a problem hiding this comment.
We still have level=info msg="creating local repository for: .....git". But reading again I'm realizing now that message is only logged on repo initialization, the next time we fetch a new PR branch you will not see anything.
Fixed in 7359f3a.
smacker
approved these changes
Dec 19, 2018
Signed-off-by: Carlos Martín <[email protected]>
Signed-off-by: Carlos Martín <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #287.