Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: support go.mod #47

Merged
merged 1 commit into from
Jul 31, 2019
Merged

build: support go.mod #47

merged 1 commit into from
Jul 31, 2019

Conversation

jfontan
Copy link
Contributor

@jfontan jfontan commented Jul 29, 2019

Also update travis to test with 1.11 and 1.12

@jfontan
build: support go.mod
c64f79f 
Also update travis to test with 1.11 and 1.12

Signed-off-by: Javi Fontan <[email protected]>
mcarmonaa
mcarmonaa approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@mcarmonaa mcarmonaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the README to reflect that now it's compatible with go modules instead of use gopkg.in/src-d/go-siva.v1?

Other than that LGTM

@jfontan
Copy link
Contributor Author

jfontan commented Jul 30, 2019 •
edited
Loading

@mcarmonaa it's compatible with go modules but also still compatible with no modules (dep, for example). Also we still use the same path (gopkg.in).

@jfontan jfontan merged commit a73bed3 into src-d:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarmonaa mcarmonaa mcarmonaa approved these changes

@mcuadros mcuadros Awaiting requested review from mcuadros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfontan @mcarmonaa