Add NewReaderWithOffset #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows opening siva files while they are being modified or opening an old index. Signed-off-by: Javi Fontan <[email protected]>
mcarmonaa
reviewed
Feb 27, 2019
index.go
Outdated
| endLastBlock, err := r.Seek(0, io.SeekEnd) | ||
| if err != nil { | ||
| return nil, err | ||
| func readIndex(r io.ReadSeeker, o uint64) (Index, error) { |
There was a problem hiding this comment.
Maybe it'd be worthy write a comment to know why readIndex and readIndexAt are different, right now it's confusing.
ajnavarro
reviewed
Feb 28, 2019
| // NewReaderWithOffset creates a new Reader giving the position of the index. | ||
| // This is useful to open siva files that are being written or reading an | ||
| // old index. | ||
| func NewReaderWithOffset(r io.ReadSeeker, o uint64) Reader { |
There was a problem hiding this comment.
what happens if the provided offset is not an index?
There was a problem hiding this comment.
Calling Index function will error. The same way it errors when opening a broken siva file.
|
Found a problem that causes index to be read every time it is accessed. Working on a fix. |
Signed-off-by: Javi Fontan <[email protected]>
mcarmonaa
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows opening siva files while they are being modified or opening an old index.