add fix for zip slip siva vulnerability #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* document `IndexEntry.Name`, including security notes. * `siva unpack` now fails if it would result in a file being extracted outside the output directory. * `Index.ToSafePaths` convenience function is provided for users who write siva extraction code and want a quick way to make it safe. Thanks to Toni Cárdenas (@tcard) for notifying us about the vulnerability and proposing a fixed. Signed-off-by: Santiago M. Mola <[email protected]>
smola
added a commit
to smola/go-siva
that referenced
this pull request
Jun 25, 2018
Code was broken after merging src-d#30 and src-d#31 together. Signed-off-by: Santiago M. Mola <[email protected]>
Merged
smola
added a commit
to smola/go-siva
that referenced
this pull request
Aug 1, 2018
Code was broken after merging src-d#30 and src-d#31 together. Signed-off-by: Santiago M. Mola <[email protected]>
smola
added a commit
that referenced
this pull request
Sep 28, 2018
* fix tests build Code was broken after merging #30 and #31 together. Signed-off-by: Santiago M. Mola <[email protected]> * fix paths on Windows, ensure closing Signed-off-by: Santiago M. Mola <[email protected]> * travis: update go versions Signed-off-by: Santiago M. Mola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexEntry.Name, including security notes.siva unpacknow fails if it would result in a file being extracted outside the output directory.Index.ToSafePathsconvenience function is provided for users who write siva extraction code and want a quick way to make it safe.For users: If you are just packing or reading siva files, there is no risk. If you are using entry names as file paths to extract them to the local filesystem you should either validate them youself, or call
ToSafePaths()on theIndexbefore using it.We'll need to add a note to release notes, something like: