Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: fix test for time.Time change on 1.9 #22

Merged
merged 4 commits into from
Feb 10, 2018

Conversation

ferhatelmas
Copy link
Contributor

No description provided.

@campoy
Copy link
Contributor

campoy commented Nov 23, 2017

I think we should not be using reflect.DeepEqual since comparing unexported fields is weak
Have you considered trying https://github.com/google/go-cmp?

@mcuadros
Copy link
Contributor

Yep for this case, will be inserting use cmp, instead of DeepEquals from gocheck

@ferhatelmas
Copy link
Contributor Author

That's a great suggestion, updated. Added two more small improvements as separate commits.

@ferhatelmas
Copy link
Contributor Author

@mcuadros @campoy ping

@kuba--
Copy link

kuba-- commented Feb 9, 2018

Hi guys, I suggest to use os.TempDir() in pack_test.go and unpack_test.go (instead of hardcoded "/tmp/"), because windows builds are failing.

...
unpack_test.go:20:
    c.Assert(err, IsNil)
... value *os.PathError = &os.PathError{Op:"CreateFile", Path:"/tmp/", Err:0x2} ("CreateFile /tmp/: The system cannot find the file specified.")

@mcuadros mcuadros merged commit ebda6e6 into src-d:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants