Skip to content

Implement getting HTML color code for languages #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bzz merged 1 commit into from
Jul 29, 2019
Merged

Implement getting HTML color code for languages #233

bzz merged 1 commit into from
Jul 29, 2019

Conversation

@lafriks
Copy link
Contributor

@lafriks lafriks commented Jul 19, 2019

Adds utility function GetColor(language string) string

@lafriks
Implement getting color code for languages
25b29eb 
Signed-off-by: Lauris Bukšis-Haberkorns <[email protected]>
@lafriks lafriks mentioned this pull request Jul 22, 2019
Closed
6 tasks
@lafriks
Copy link
Contributor Author

lafriks commented Jul 24, 2019

Is there anything else I need to do to get this merged?

@creachadair
Copy link
Contributor

creachadair commented Jul 24, 2019

Is there anything else I need to do to get this merged?

Sorry for the delay. @bzz who maintains this repo is out of the office this week, but should be able to take a look when he gets back. The change looks fine from a functional perspective, but I'd like Alex's feedback on whether it makes sense to include it.

@creachadair creachadair requested a review from bzz July 24, 2019 16:50
@bzz
Copy link
Contributor

bzz commented Jul 29, 2019

Sorry for delay, great job @lafriks, LGTM.

It would be also interesting to know if you could share about your use-case for this feature!

@bzz bzz merged commit ee9d089 into src-d:master Jul 29, 2019
@lafriks lafriks deleted the feat/lang_colors branch July 29, 2019 15:46
@lafriks
Copy link
Contributor Author

lafriks commented Jul 29, 2019

@bzz no problems, I'm one of core Gitea contributors and currently implementing repository language statistics bar like in Github, see back-reference above for Gitea PR that is currently wip

@lafriks
Copy link
Contributor Author

lafriks commented Jul 29, 2019 •
edited
Loading

Btw thanks for this great library that made this possible to add that to Gitea ;)

@lafriks lafriks mentioned this pull request Aug 29, 2019
Merged
6 tasks
@bzz bzz mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bzz bzz bzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lafriks @creachadair @bzz