Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix packages and deploy #63

Closed
wants to merge 1 commit into from
Closed

ci: fix packages and deploy #63

wants to merge 1 commit into from

Conversation

smola
Copy link
Contributor

@smola smola commented May 16, 2018

Signed-off-by: Santiago M. Mola [email protected]

@smola smola requested a review from campoy May 16, 2018 08:33
@smola
Copy link
Contributor Author

smola commented May 16, 2018

This should fix #54
I tested make packages locally, but Travis deploy is not tested yet.

Signed-off-by: Santiago M. Mola <[email protected]>

# Including ci Makefile
CI_REPOSITORY ?= https://github.com/src-d/ci.git
CI_PATH ?= $(shell pwd)/.ci
CI_VERSION ?= v1
PKG_OS=linux darwin windows
PKG_OS = linux darwin windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was that really the problem?

(╯°□°)╯︵ ┻━┻)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really ;)
I think the problem is in the travis.yml commands. I updated the PR. make packages should be used to compile the binaries and create the tars, then a single file blob expression can be used in the deploy section for Travis to pick up everything.

@smola
Copy link
Contributor Author

smola commented Jun 18, 2018

@campoy Is it ok publishing a single tarball with pga, multitool and borges-indexer binaries? That's our default behavior for make packages, but we can keep previous behavior (tarball per binary) approach if needed.

@campoy
Copy link
Contributor

campoy commented Jun 19, 2018

It'd be fine ... but I think it's better to provide a way to download each binary separately to be honest.

@vmarkovtsev
Copy link
Collaborator

@smola @jfontan Shall we close this?

@jfontan
Copy link
Contributor

jfontan commented Apr 12, 2019

I believe so. Windows is still not supported but there's an issue for that (#103)

@smola smola closed this Apr 15, 2019
@smola smola deleted the fix-deploy branch April 15, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants