Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing import to gogo in proteus example #227

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Add a missing import to gogo in proteus example #227

merged 1 commit into from
Sep 5, 2018

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Jul 3, 2018

No description provided.

bzz
bzz approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shall we merge it?

@dennwc
Copy link
Contributor Author

dennwc commented Jul 18, 2018

Sure, just waiting for someone who maintains it :)

@smola smola requested a review from campoy July 24, 2018 12:18
@bzz
Copy link
Contributor

bzz commented Jul 24, 2018

@campoy friendly ping

@campoy
Copy link
Contributor

campoy commented Jul 25, 2018

TBH I'm approving this just because it looks good, I'm assuming we actually tried to compile it?

@vmarkovtsev vmarkovtsev merged commit bba51e9 into src-d:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@campoy campoy campoy approved these changes

@vmarkovtsev vmarkovtsev vmarkovtsev approved these changes

@bzz bzz bzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dennwc @bzz @campoy @vmarkovtsev