PHP 8.0 | Tokenizer/PHP: support dereferencing of text strings with interpolated variables #3172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith interpolated variables As of PHP 8, interpolated text strings can be dereferenced, however, the square brackets are incorrectly tokenized as _short array_ brackets instead of as "normal" square brackets. Fixed by adding the `T_DOUBLE_QUOTED_STRING` token to the allowed tokens for leaving the brackets alone in the PHP Tokenizer class. Includes unit test. Ref: https://wiki.php.net/rfc/variable_syntax_tweaks#interpolated_and_non-interpolated_strings
jrfnl
force-pushed
the
php-8.0/tokenizer-interpolated-string-dereferencing
branch
from
9357705 to
3cd1f67
Compare
Member
|
Thanks! I wasn't aware of this change. |
jrfnl
deleted the
php-8.0/tokenizer-interpolated-string-dereferencing
branch
Contributor
Author
|
One of those which easily slips through the cracks, only just noticed it the other day myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8, interpolated text strings can be dereferenced, however, the square brackets are incorrectly tokenized as short array brackets instead of as "normal" square brackets.
Fixed by adding the
T_DOUBLE_QUOTED_STRINGtoken to the allowed tokens for leaving the brackets alone in the PHP Tokenizer class.Includes unit test.
Ref: https://wiki.php.net/rfc/variable_syntax_tweaks#interpolated_and_non-interpolated_strings