Bug fix: don't apply include/exclude patterns to STDIN #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: using `trim()` to remove potential quotes around `STDIN` which are sometimes passed by IDEs.
Note: using `trim()` to remove potential quotes around `STDIN` which are sometimes passed by IDEs.
|
Tested, it works. Thanks! :D |
jrfnl
deleted the
feature/3107-dont-check-stdin-against-ignore-include-paths
branch
Contributor
Author
|
@gsherwood Uh.. I thought you wanted to wait with including this change for v 3.6.0 ? It's not included in the 3.5.7 changelog now. |
Member
|
No idea how that got in there - must have forgotten to remove it. Thanks for letting me know. Will release 3.5.8 today with this reverted. |
Contributor
Author
|
@gsherwood Would you like me to resubmit the PR or will you just cherrypick the commits from the earlier merge ? |
Member
I was just going to cherry pick them. |
gsherwood
added a commit
that referenced
this pull request
Oct 26, 2020
Member
|
Thanks for the PR. It's been merged in again now. And that's again for letting me know it was in the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents code passed via
STDINfrom not being scanned becauseSTDINis not part of an include/exclude pattern.I've made the same adjustment to both the
File::process(), as well as theFile::addMessage()method.Note: using
trim()to remove potential quotes aroundSTDINwhich are sometimes passed by IDEs. (based on previous experiences with sniffs checking file names).Also note that the changes look more extensive than they really are due to the indentation change. Looking at the files while ignoring whitespace changes will show the real diff (4 lines).
Fixes #3107