File::isReference(): bug fix - arrow function params passed by reference #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `&` for parameters passed by reference in an arrow function declaration were incorrectly not recognized as references. This is the root cause of issue 3049, which affected the `PSR12.Operators.OperatorSpacing` and the `Squiz.WhiteSpace.OperatorSpacing` sniffs (and possibly/probably more sniffs). Includes unit test. Fixes 3049
This was referenced Sep 5, 2020
gsherwood
added a commit
that referenced
this pull request
Sep 29, 2020
|
Thanks a lot for this fix. It did indeed fix both of the issues reported. It has been merged in, but I was doing a rebase and the commit hashes got changed over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
&for parameters passed by reference in an arrow function declaration were incorrectly not recognized as references.This is the root cause of issue #3049, which affected the
PSR12.Operators.OperatorSpacingand theSquiz.WhiteSpace.OperatorSpacingsniffs (and possibly/probably more sniffs).Includes unit test.
Fixes #3049