Tokenizer does not change heredoc to nowdoc token if the start tag contains spaces #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spaces "<<< 'EOF'" is a valid nowdoc start tag.
michalbundyra
force-pushed
the
hotfix/nowdoc
branch
from
48ee87a
to
0120593
Compare
gsherwood
changed the title
gsherwood
added a commit
that referenced
this pull request
Apr 4, 2018
…f the start tag contains spaces
|
Thanks for reporting this, although I fixed it using a strpos rather than using a regex because it is faster and PHP wont allow things like newlines and comments as part of that tag. If you've think I've made a mistake there, please let me know. |
|
@gsherwood Solution with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<<< 'EOF'is a valid nowdoc start tag (there could be more than one space, or even tab ...)