don't assume numeric line numbers #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This PR isn't showing any changes, but it looks like the commit is here: classmarkets@49429f1 Looks like a good change, so I'll merge it in if you can add that code to the PR. |
Contributor
Author
|
I guess changing branch names after submitting a pull request isn't a good idea :) |
Member
|
Thanks for doing that. Merged cleanly now. |
jrfnl
added a commit
to jrfnl/PHP_CodeSniffer
that referenced
this pull request
Jul 29, 2024
…-embeddedphp-support-short-open-tag Squiz/EmbeddedPhp: add support for short open tag and various bug fixes
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP_CodeSniffer_Reports_Fullassumes that line numbers in the report are numeric. This isn't always the case. We use this class to display custom reports and that yield line ranges, such as "112 - 118".So, if a report has two messages, for lines "156 - 172" and "27", the width for the line column is determined as 2, because "27" > "156 - 172".
This PR calculates the actual maximum string length.